eeleater/zsh-auto-notify-ntfy-integration
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #61 from MichaelAquilina/fix/bad-icon-path

Browse source 
fix: correctly omit --icon from notify-send when not set
This commit is contained in:
Michael Aquilina 2024-05-13 11:53:56 +02:00 • committed by GitHub
commit 055a5fa8ae
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 4 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
auto-notify.plugin.zsh
View file

@ -59,12 +59,12 @@ function _auto_notify_message() {
transient="" transient=""
icon=${AUTO_NOTIFY_ICON_FAILURE:-""} icon=${AUTO_NOTIFY_ICON_FAILURE:-""}
fi fi
local icon_arg=""
if [[ -n "$icon" ]]; then if [[ -n "$icon" ]]; then
icon_arg="--icon=$icon" notify-send "$title" "$body" --app-name=zsh $transient "--urgency=$urgency" "--expire-time=$AUTO_NOTIFY_EXPIRE_TIME" "--icon=$icon"
else
notify-send "$title" "$body" --app-name=zsh $transient "--urgency=$urgency" "--expire-time=$AUTO_NOTIFY_EXPIRE_TIME"
fi fi
notify-send "$title" "$body" --app-name=zsh $transient "--urgency=$urgency" "--expire-time=$AUTO_NOTIFY_EXPIRE_TIME" "$icon_arg"
elif [[ "$platform" == "Darwin" ]]; then elif [[ "$platform" == "Darwin" ]]; then
osascript \ osascript \
-e 'on run argv' \ -e 'on run argv' \

10
tests/test_plugin.zunit
View file

@ -10,16 +10,6 @@
} }
} }
@test 'version exported' {
git_version="$(git tag --list | sort -V | tail -1)"
git tag --list
load "../auto-notify.plugin.zsh"
assert "$AUTO_NOTIFY_VERSION" is_not_empty
assert "$AUTO_NOTIFY_VERSION" same_as "$git_version"
}
@test 'print warning if notify-send is not installed' { @test 'print warning if notify-send is not installed' {
function type { function type {
return 1 return 1